TomNeyland / angular-dc

AngularJS directives for dc.js
http://tomneyland.github.io/angular-dc/
MIT License
112 stars 59 forks source link

Fix bower reference #4

Closed TomNeyland closed 10 years ago

TomNeyland commented 10 years ago

@tardyp

I went to register angular-dc with bower but noticed you had already registered the name, can you point bower to the main repository?

tardyp commented 10 years ago

Hi, Sorry, as you were not too responsive, and I needed this on bower, I registered the name. It looks like you cannot change the repository unless you make a comment on that issue: https://github.com/bower/bower/issues/120

If you commit on maintaining it keeping this stable, I can give you the name back.

Pierre

On Mon, Apr 7, 2014 at 12:25 AM, Tom Neyland notifications@github.comwrote:

@tardyp https://github.com/tardyp

I went to register angular-dc with bower but noticed you had already registered the name, can you point bower to the main repository?

Reply to this email directly or view it on GitHubhttps://github.com/TomNeyland/angular-dc/issues/4 .

TomNeyland commented 10 years ago

@tardyp It'd be great if you could get the name transferred back. We are now using angular-dc at my office and so I will be able to give it increased attention.

Additionally, you are interested I'd be more than willing to add you as a contributor to this repo.

tardyp commented 10 years ago

I think the best for everybody is to actually have this project hosted on dc.js group. I'll file a bug on dc.js to ask this.

Pierre

On Thu, Jun 12, 2014 at 7:58 PM, Tom Neyland notifications@github.com wrote:

@tardyp https://github.com/tardyp It'd be great if you could get the name transferred back. We are now using angular-dc at my office and so I will be able to give it increased attention.

Additionally, you are interested I'd be more than willing to add you as a contributor to this repo.

Reply to this email directly or view it on GitHub https://github.com/TomNeyland/angular-dc/issues/4#issuecomment-45926032.

tardyp commented 10 years ago

also, please note that the website's example are broken. I've fix them in my branch. you probably just need to update the branch

Pierre

On Thu, Jun 12, 2014 at 9:52 PM, Pierre Tardy tardyp@gmail.com wrote:

I think the best for everybody is to actually have this project hosted on dc.js group. I'll file a bug on dc.js to ask this.

Pierre

On Thu, Jun 12, 2014 at 7:58 PM, Tom Neyland notifications@github.com wrote:

@tardyp https://github.com/tardyp It'd be great if you could get the name transferred back. We are now using angular-dc at my office and so I will be able to give it increased attention.

Additionally, you are interested I'd be more than willing to add you as a contributor to this repo.

Reply to this email directly or view it on GitHub https://github.com/TomNeyland/angular-dc/issues/4#issuecomment-45926032 .

TomNeyland commented 10 years ago

@tardyp

I think the best for everybody is to actually have this project hosted on dc.js group.

I'd consider it but it is rude of you to hold my project hostage.

TomNeyland commented 10 years ago

also, please note that the website's example are broken. I've fix them in my branch. you probably just need to update the branch

I'll gladly pull in the fix, thank you

TomNeyland commented 10 years ago

@tardyp we can continue the discussion on the other issue thread if you prefer:

https://github.com/dc-js/dc.js/issues/616

Again, I am potentially open to this, but I am not a fan of you forcing the issue.

tardyp commented 10 years ago

Hi Tom,

I am sorry if I sounded rude. This was certainly not my intention. For me this org solution is really the obvious way to have several people collaborating on the same project.

Doing a specific org just for angular-dc sounds overkill. Being hosted by dc-js sounds much better way of getting attention and trust from other potential users. dc-js people liked the idea, and promptly created the team in their org.

I have already angular-dc in production in one of my company internal server with continuous deployment relying on bower. So this is why I cannot just release the bower package reference, and why I really want to make sure this project will be maintained.

Regards,

Pierre

On Thu, Jun 12, 2014 at 11:04 PM, Tom Neyland notifications@github.com wrote:

@tardyp https://github.com/tardyp we can continue the discussion on the other issue thread if you prefer:

dc-js/dc.js#616 https://github.com/dc-js/dc.js/issues/616

Again, I am potentially open to this, but I am not a fan of you forcing the issue.

— Reply to this email directly or view it on GitHub https://github.com/TomNeyland/angular-dc/issues/4#issuecomment-45947847.

TomNeyland commented 10 years ago

I have already angular-dc in production in one of my company internal server with continuous deployment relying on bower. So this is why I cannot just release the bower package reference, and why I really want to make sure this project will be maintained.

In this situation the best practice by far is to install the package using the URL of your fork. Installing a package from a git URL is simple to do and is supported exactly for this sort of reason.

The following configuration is how you would instruct bower to install the package from your fork:

{
    "name": "foo/bar",
    "dependencies": {
        "angular-dc": "git@github.com:tardyp/angular-dc.git"
    }
}

Or if you want to point bower at a specific tagged release:

{
    "name": "foo/bar",
    "dependencies": {
        "angular-dc": "git@github.com:tardyp/angular-dc.git#0.0.1"
    }
}

One of the main benefits of installing the library this way is that it gives you ultimate authority over what code makes it into your production codebase-- allowing you to vet any changes made upstream before merging them into your fork. For this reason, I'd suspect those responsible for your application security and integrity would much prefer you install via your fork anyway-- as it removes an entire vector by which an attacker could inject malicious code into your application.

I have been pleased with the pull requests you have submitted so far and thank you for your contributions. I would love to continue seeing pull requests come from your fork.

For the moment I have decided not to transfer the repository over-- the main repo already has several stars and forks, and since the fork + pull request methodology allows collaboration to be managed quite nicely already, I see no need to transfer it.

I have gone ahead and made a request on the bower issue that they point the bower package back at this original repository, and would suggest that you consider updating your bower.json file to point at your fork as shown above.

gordonwoodhull commented 10 years ago

ok i will cancel the angular-dc team on dc-js. glad you guys were able to resolve this.

tardyp commented 10 years ago

ok, this is your choice. I disagree, and respect it.

I deleted the bower reference using the github token based api. Please recreate ASAP, pointing to your repo.

TomNeyland commented 10 years ago

The reference has been updated, thank you.