search

TomNisbet / TommyPROM

Simple Arduino-based EEPROM programmer
https://tomnisbet.github.io/TommyPROM/
143 stars 29 forks source link

TommyPROM v2.2 '595 Shift Register code has introduced a bug #15

Closed NigelTwo closed 3 years ago

NigelTwo commented 3 years ago

I downloaded the V2.2 code to verify the Xmodem fix. Some new code has been added to support '595 shift registers. I enabled the define, and verified that my hardware was setup as per the revised documentation. Yes I had used D13 as the RCLK pin too. So no wiring changes were needed. Eeek, it didn't work.

I think the problem is this define in PromAddressDriver.cpp that is used in setAddressRegister(): `// Define masks for the address clk and data lines on PC3..PC5 for direct port control.

define ADDR_CLK_HI_MASK 0x80`

This was 0x08 in V2.0 of the code, where no define was used. Or am I going mad?

TomNisbet commented 3 years ago

Good catch. Of course my quick test worked because I just zapped a pattern in that didn't cross a 256 byte boundary!

NigelTwo commented 3 years ago

@TomNisbet This is a good enhancement, so I am pleased to have helped.

NigelTwo commented 3 years ago

@TomNisbet - The conditional code for the '595 shift registers is not being included in PromAddressDriver.cpp in my environment. Have to include the Configure.h???