Closed chefnobody closed 8 years ago
Hi chefnobody, Thanks for the thought you've clearly put into this. I'm swamped with work at the moment but will try and look at this soon. On initial glance I agree with your comments though :-) Tom
Hi @chefnobody,
Sorry for my brief reply earlier. I've had a quick look at the code and it looks great. On your point about the number formatter you are spot on - what you've done is much better than before so thanks for updating that and fixing my hack!
Merging :-)
Tom
Cheers Tom! Thanks!
…. Why? Two main reasons:
NSNull
orAnyObject
toNSNumberFormatter
and get back anNSNull
in Obj-C. I was only ever able to get anil
which the other sort of unclear use-case in the API. If you set this property tonil
you get no formatter style. Anyway ... I just wanted to turn off the labels. Seems to me a flag would be a much cleaner way to go about it.What I've done:
IBInspectable
flag namedhideLabels
which by default is set toNO
. Setting it toYES
ortrue
will hide them. I've made sure that updating this property while building the UI will correctly update the Storyboard/XIB. Updated the comment in the header.