search

TomThorpe / TTRangeSlider

A slider, similar in style to UISlider, but which allows you to pick a minimum and maximum range.
MIT License
968 stars 203 forks source link

Allow greater than max value #42

Closed lpenaflor closed 7 years ago

lpenaflor commented 8 years ago

This returns $150+ if enabled. Use case is when we need to indicate to the user that we can include a greater than max value in the range selected.

TomThorpe commented 7 years ago

Hey! Many thanks for this, I really appreciate it. However, I'm a bit concerned that the API for this is getting a bit too complicated, and this is quite a niche requirement (I hope you agree!)

I think in this case I'd prefer people to just use a custom numberFormatterOverride for the + symbol (add the plus symbol to the number when it's at its maximum), then use logic to determine whether its infinite, instead of specifically having this ability in the control and perhaps complicating it more than it needs to be.

Thanks though, and sorry! I hope you agree with my reasoning? I really appreciate people helping out and doing PRs but lately the list of properties and options is getting longer and longer :-)

lpenaflor commented 7 years ago

Hey @TomThorpe, it's been awhile since I've looked at this. I do agree the solution may have been over-engineered, I believe it's quite common for sliders, specifically for pricing do use a greater than system. I hope for a simpler solution and even a separate delegate that handles the use of greater than. No worries on not merging this in, I just thought I'd chime in on the need for + and - indicators