search

TomThorpe / TTRangeSlider

A slider, similar in style to UISlider, but which allows you to pick a minimum and maximum range.
MIT License
968 stars 204 forks source link

Customize left & right handle. #82

Closed ened closed 6 years ago

ened commented 6 years ago

Simple customization added for left & right handle color.

TomThorpe commented 6 years ago

Hey!

Thanks a lot for your PR - it's much appreciated :-) I think thought it would be best not to remove handleColor as this becomes a breaking change (hence travis failing), and I've tried to avoid those up until now. It might be best to just have the behaviour of the min and max handles only take the colour if it exists, or use handleColor if not?

It's no worries if you dont want to implement this and just wanted your simple change - but I can't reallt merge this for now, sorry!

Thanks again! Tom

ened commented 6 years ago

@TomThorpe I re-added the handleColor setter. I'd like to update the demo app to include the new min/max handle colors as well. However, the demo app currently targets iOS 8.. I think we could raise the minimum to iOS 10 (and switch layouting in there to StackViews). For the library itself.. perhaps also raise to iOS 10?

TomThorpe commented 6 years ago

Sorry for the delay on this! Yes looks great now, thanks so much for your help.

Great idea about the stack views. If I’m not mistaken they were introduced in ios9 so I don’t see a big need to raise the minimum to ios10 just yet (I always try to maintain two major versions back, and iOS 12 isn’t out yet) - but ios9 and stackviews for sure! :-)

Thanks again for your help!