search

TomTranter / JellyBaMM

Couple pybamm and openpnm to solve a thermal battery problem
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Examples not working #11

Closed Saransh-cpp closed 2 years ago

Saransh-cpp commented 2 years ago

I was going through the repository and I found that the examples available as jupyter notebooks error out -

  1. current-density-distribution.ipynb - The files var_Current_collector_current_density_lower.mat, var_Current_collector_current_density_upper.mat, and MJ141-mid-top_m_cc_new.pnm are missing. 2 of these files are available in the tests folder but there isn't any 8A subdirectory present there.
  2. solution-data-and-processed-variables.ipynb - Is this notebook supposed to be the same as the one in PyBaMM? There were a few PyBaMM errors in this notebook like the variable name 'Negative particle surface concentration' is without units.
  3. The third notebook doesn't open as the JSON is invalid. I tried fixing the JSON but then it started giving another error.

And I also wanted to ask if the scripts in the run_scripts folder are example scripts? I am also facing some issues with them but I don't know if they are supposed to run independently.

TomTranter commented 2 years ago

Hi @Saransh-cpp thanks for the info. Perhaps better hold off testing this until it's a little more robust. I'm going to completely overhaul the solver and with that the output variables will be the way liionpack does them

TomTranter commented 2 years ago

I am going to move examples into docs PR