TomTranter / JellyBaMM

Couple pybamm and openpnm to solve a thermal battery problem
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Issue with cc heating #18

Open jvgoetze opened 2 years ago

jvgoetze commented 2 years ago

I'm having some trouble with running the normal tab design and recreating the results from the 46800 paper, as the cc ohmic heating always diverges, resulting in extremely high temperatures. Is this a known issue?

TomTranter commented 2 years ago

Oh hey there @jvgoetze . Sorry I didn't notice this issue you raised. If you don't tag me I won't necessarily get the notification in github as I wasn't checking this repository much recently. My plan is to bring this code under the official pybamm-team organization and I am half way through a big refactor to the solver but cc heating shouldn't be too affected by that. I was not aware of any run away heating in the scripts I was running for the 46800 paper. Can you upload the files to reproduce the errors you are seeing?