TomTranter / JellyBaMM

Couple pybamm and openpnm to solve a thermal battery problem
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Hello Stargazers #25

Closed TomTranter closed 6 months ago

TomTranter commented 2 years ago

Hi @helgestein and @mklanac, I noticed you both starred this repo so have some interest in it. I guess you read one of my papers or noticed it used PyBaMM. I'm in the middle of a big refactor so thought I'd get in touch in case you would like to get more involved in the development. There are plenty of things to do and just having some extra QA on hand would be useful. I intend to tidy it all up and transfer it to the pybamm-team organisation and then publish a paper on the code in JOSS like I have recently done for liionpack https://joss.theoj.org/papers/10.21105/joss.04051 Any help would mean we could co-author the paper. Thanks

helgestein commented 2 years ago

Hey Tom,

sounds great though I currently have zero free resources unfortunately but I might point one of my colleagues to this who is doing most of the parametrization now. Happy to beta test tough :) Keep up the great work and cheers, Helge

On 24. May 2022, at 17:56, Tom Tranter @.***> wrote:

Hi @helgestein https://github.com/helgestein and @mklanac https://github.com/mklanac, I noticed you both starred this repo so have some interest in it. I guess you read one of my papers or noticed it used PyBaMM. I'm in the middle of a big refactor to thought I'd get in touch in case you would like to get more involved in the development. There are plenty of things to do and just having some extra QA on hand would be useful. I intend to tidy it all up and transfer it to the pybamm-team organisation and then publish a paper on the code in JOSS like I have recently done for liionpack https://joss.theoj.org/papers/10.21105/joss.04051 https://joss.theoj.org/papers/10.21105/joss.04051 Any help would mean we could co-author the paper. Thanks

— Reply to this email directly, view it on GitHub https://github.com/TomTranter/pybamm_pnm/issues/25, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUIEFMKVVQZG64MDOQI2GLVLT33DANCNFSM5W2CFBYA. You are receiving this because you were mentioned.