TomTranter / JellyBaMM

Couple pybamm and openpnm to solve a thermal battery problem
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

About ecm package #31

Closed Jadhav-Sourabh closed 6 months ago

Jadhav-Sourabh commented 1 year ago

@TomTranter @rtimms

"ecm" package is depend on the python in between 2.5 to 2.9. and remaining packages will depend on python above 3.0

How can I use this? because of the "ecm" package, I am not able to do any simulation.

please help me.

TomTranter commented 1 year ago

I don't know where you are getting this information? Can you share screenshots? I haven't pinned ecm to version 2 at all. Never used it. FYI this package is not intended for general public use yet. Still working on major overhaul

Jadhav-Sourabh commented 1 year ago

In one of the example notebook, you have used import ecm.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Tom Tranter @.> Sent: Thursday, January 19, 2023 10:17:49 PM To: TomTranter/pybamm_pnm @.> Cc: Sourabh Jadhav @.>; Author @.> Subject: Re: [TomTranter/pybamm_pnm] About ecm package (Issue #31)

I don't know where you are getting this information? Can you share screenshots? I haven't pinned ecm to version 2 at all. Never used it. FYI this package is not intended for general public use yet. Still working on major overhaul

— Reply to this email directly, view it on GitHubhttps://github.com/TomTranter/pybamm_pnm/issues/31#issuecomment-1397289044, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU7LVHVHAW3D3WEYNTXTGTLWTFV3LANCNFSM6AAAAAAUAMNJ74. You are receiving this because you authored the thread.Message ID: @.***>

Jadhav-Sourabh commented 1 year ago

Okay got it. I was trying to simulate jelly roll thermal model using your package.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Sourabh Jadhav @.> Sent: Thursday, January 19, 2023 10:19:46 PM To: TomTranter/pybamm_pnm @.>; TomTranter/pybamm_pnm @.> Cc: Author @.> Subject: Re: [TomTranter/pybamm_pnm] About ecm package (Issue #31)

In one of the example notebook, you have used import ecm.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Tom Tranter @.> Sent: Thursday, January 19, 2023 10:17:49 PM To: TomTranter/pybamm_pnm @.> Cc: Sourabh Jadhav @.>; Author @.> Subject: Re: [TomTranter/pybamm_pnm] About ecm package (Issue #31)

I don't know where you are getting this information? Can you share screenshots? I haven't pinned ecm to version 2 at all. Never used it. FYI this package is not intended for general public use yet. Still working on major overhaul

— Reply to this email directly, view it on GitHubhttps://github.com/TomTranter/pybamm_pnm/issues/31#issuecomment-1397289044, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU7LVHVHAW3D3WEYNTXTGTLWTFV3LANCNFSM6AAAAAAUAMNJ74. You are receiving this because you authored the thread.Message ID: @.***>

Jadhav-Sourabh commented 1 year ago

Can you please help to simulate jelly roll thermal model? Help me with installing ecm package

TomTranter commented 1 year ago

Oh I see, that's an existing package. yeah it's also what I have called this one. In the process of renaming it JellyBaMM or something. I can help but not immediately. Like I said, it's still being reworked

TomTranter commented 1 year ago

See here for how help on installation https://github.com/TomTranter/pybamm_pnm/blob/main/.github/workflows/test_on_push.yml

Jadhav-Sourabh commented 1 year ago

Can you please share some reference papers or books for this modeling?


From: Tom Tranter @.> Sent: Thursday, January 19, 2023 10:51:17 PM To: TomTranter/pybamm_pnm @.> Cc: Sourabh Jadhav @.>; Author @.> Subject: Re: [TomTranter/pybamm_pnm] About ecm package (Issue #31)

See here for how help on installation https://github.com/TomTranter/pybamm_pnm/blob/main/.github/workflows/test_on_push.yml

— Reply to this email directly, view it on GitHubhttps://github.com/TomTranter/pybamm_pnm/issues/31#issuecomment-1397338393, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU7LVHUB3VI57O7XYZREXQDWTFZY3ANCNFSM6AAAAAAUAMNJ74. You are receiving this because you authored the thread.Message ID: @.***>

TomTranter commented 1 year ago

https://iopscience.iop.org/article/10.1149/1945-7111/aba44b/meta https://iopscience.iop.org/article/10.1149/1945-7111/abd44f/meta

Jadhav-Sourabh commented 1 year ago

Sir,

I read the papers and I want to appreciate you. You are doing a great job.


From: Tom Tranter @.> Sent: Friday, January 20, 2023 1:43:09 PM To: TomTranter/pybamm_pnm @.> Cc: Sourabh Jadhav @.>; Author @.> Subject: Re: [TomTranter/pybamm_pnm] About ecm package (Issue #31)

https://iopscience.iop.org/article/10.1149/1945-7111/aba44b/meta https://iopscience.iop.org/article/10.1149/1945-7111/abd44f/meta

— Reply to this email directly, view it on GitHubhttps://github.com/TomTranter/pybamm_pnm/issues/31#issuecomment-1398047028, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AU7LVHXHQUGNAE3ECTOJEMTWTJCJLANCNFSM6AAAAAAUAMNJ74. You are receiving this because you authored the thread.Message ID: @.***>