Update Code for Dependency Changes

TomTranter / JellyBaMM

Couple pybamm and openpnm to solve a thermal battery problem

BSD 3-Clause "New" or "Revised" License

11 stars 5 forks source link

Update Code for Dependency Changes #33

Closed mleot closed 6 months ago

mleot commented 6 months ago

Primary Changes were to the openpnm function calls to reflect V3.0 and above syntax.

mleot commented 6 months ago

@TomTranter I did a few more tests to see whether the liionpack steps or the OpenPNM steps were causing the slowdown, and I think I've determined it is indeed openpnm taking a long time to solve. I am using their updated methods to obtain the transient solution, but there is an option to use the legacy solver, or use a different integrator. Using the alternate integrator did speed things up by some amount.

TomTranter commented 6 months ago

@mleot I pinned the version we were using for OpenPNM to avoid these kinds of thing. I haven't kept pace with the developments there and thought going forward we would want to solve the thermal problem and global electrical problem in PyBaMM - I'm not sure it's worth pursuing updating OpenPNM

mleot commented 6 months ago

Closing this pull request