Update - Tanners changes into Tom's Changes

TomTranter / JellyBaMM

Couple pybamm and openpnm to solve a thermal battery problem

BSD 3-Clause "New" or "Revised" License

11 stars 5 forks source link

Update - Tanners changes into Tom's Changes #35

Closed mleot closed 6 months ago

mleot commented 6 months ago

I extracted the necessary changes for the version that was working for me.

Still not updated are the:

setup.py and the requirement version numbers
External dependency (openpnm dev branch for other integrators)

mleot commented 6 months ago

I realized that I didn't adjust some of the power loss functions to apply the heat after each step. I have adjusted these and will add them into this PR soon.