TomWhitwell / Chord-Organ

39 stars 21 forks source link

Feature/chord banks #8

Open starmandeluxe opened 7 years ago

starmandeluxe commented 7 years ago

I have successfully implemented the concept of "banks" for the Chord Organ in the spirit of Radio Music. The number of banks is determined by the number of chord files: same as the original chord file format, just copies of these can now be made to add banks. The files must begin with "chord" and end in ".txt" (both case insensitive). There can be anywhere from 1-16 banks. These are loaded into memory on startup so no performance hits from reading the SD card while operation is in progress. To actually change banks during use, simply long-hold the RESET/Waveform button until the LEDs change. The current bank is shown in binary. Let go to stop scrolling banks and select that one (bank will not actually change until finger is lifted ^_^). That's all there is to it.

I also found a major bug with parsing the first note in each chord (not certain if it was present before). It was grabbing the first "[" and thinking that was part of the note. This has been fixed.

In general I also cleaned up formatting for readability and maintainability.