TomWhitwell / RadioMusic

Virtual Radio module for Eurorack
328 stars 91 forks source link

New option to add local settings for each bank #192

Open dessertplanet opened 4 months ago

dessertplanet commented 4 months ago

I've implemented per-bank settings! The hack/trade-off is that when you switch banks, I reboot to reload audioEngine etc gracefully but this happens VERY fast.

This does preclude you from holding reset to switch banks multiple times, one long-press buys one bank switch and new local.txt settings are loaded if and only if settings.txt at the root has local=1.

To sum up:

THANK YOU for this wonderful instrument and all of your other work!

TomWhitwell commented 4 months ago

Hi, thank you for this - it's a really interesting idea - unfortunately I'm not going to merge it because I think that the "holding reset to switch banks multiple times" function is too important.

dessertplanet commented 4 months ago

Makes perfect sense! Also upon further testing I have noticed it breaks the binary bank display. One possible solution would be to load settings (and reboot) only upon button release? So toggle through a bunch of banks, load the settings of the last one? Let me know if that might work. Otherwise totally get that this is an old project and I have already learned a lot from hacking together some basic changes.

dessertplanet commented 3 months ago

@TomWhitwell managed to tweak it so that switching banks multiple times works. Only potential issue now is the pop on reset. I seem to get a pop sound whenever the reBoot method is called. Not sure this is avoidable on the hardware, since the same pop happens with no SD when the reset timer runs out. Might be worth testing on your hardware before merging to see if it is worth it. All of this still optional behind the new "local" setting in SETTINGS.TXT of course.

I also have a cleaner branch with consolidated commits if that is preferred!