search

TomWhitwell / SlowMovie

MIT License
351 stars 69 forks source link

Estimate runtime refactoring #117

Closed yippieyaray closed 2 years ago

yippieyaray commented 2 years ago

This is my refactoring of the estimate_runtime function to fix "Runtime estimation problem #115 (https://github.com/TomWhitwell/SlowMovie/issues/115)" It's not my quick fix from yesterday. I remove all unnecessary loops and recursions as well.

robweber commented 2 years ago

The changes make sense to me. I ran the new function in it's own file with a variety of different increments and frame values without issue. The only spot I can find this function is called is when the remaining time is logged. For it's intended purpose I think making it as lightweight as possible is a good change.

@qubist - I think you may have originally added this function. Any thoughts?

qubist commented 2 years ago

If merged, this closes #115

qubist commented 2 years ago

Thanks for moving forward with this, @missionfloyd !