For the first one the service install process was not working properly as it wasn't generating the service file from the template as expected. Some reconfiguring of the service install process was done to fix this. I added a copy_service_file function to keep all this code in the same spot. The install_slowmovie function now calls install_service directly when it notices the service is installed during an upgrade. install_service now branches to either do a new service install or an upgraded service (if necessary).
For the second bug I actually found this while trying to fix the first one. When selecting "no" to the service install question the entire script was just closing out instead of continuing properly. I played around with whiptail a bunch but it just didn't seem to be returning the variable properly no matter what I did. Storing the result directly using either $? or assigning it as part of the call all resulted in the script crashing. Wrapping everything in an if statement was the only way I could get it to function. Now the INSTALL_SERVICE variable is set based on the yes/no action instead of storing the output of whiptail directly. This worked when testing in all scenarios (selecting yes or no during clean install).
These should fix both #140 and #141.
For the first one the service install process was not working properly as it wasn't generating the service file from the template as expected. Some reconfiguring of the service install process was done to fix this. I added a
copy_service_file
function to keep all this code in the same spot. Theinstall_slowmovie
function now callsinstall_service
directly when it notices the service is installed during an upgrade.install_service
now branches to either do a new service install or an upgraded service (if necessary).For the second bug I actually found this while trying to fix the first one. When selecting "no" to the service install question the entire script was just closing out instead of continuing properly. I played around with
whiptail
a bunch but it just didn't seem to be returning the variable properly no matter what I did. Storing the result directly using either$?
or assigning it as part of the call all resulted in the script crashing. Wrapping everything in anif
statement was the only way I could get it to function. Now theINSTALL_SERVICE
variable is set based on the yes/no action instead of storing the output of whiptail directly. This worked when testing in all scenarios (selecting yes or no during clean install).