Open Toma400 opened 2 years ago
This, eventually, failed. Look at those commits to see the difference (mostly on entries_manag module)
Current idea to implement: let's switch all Value
objects into simple dictionary, and let's make return_attr
use similar syntax as with open
, meaning you input string to get specific return mode. Value Dict could have specific name part (just like "__" is done for separating vanilla and plugin translation keys) or just have one more value being readen, or whatever.
It should be bitta different because we have already custom translation dict and any supporting dicts can appear later as well.
So, as of creating DB3, I faced the issue of object comparisons wielding different outcomes. This means that this function:
returns two differently named classpaths, making comparison not possible (therefore, return always results in empty list) not because classes are different, but because they have weirdly different classpath. So, one cannot iterate in such way in layout menu:
because
vallist
is always empty.The idea for now is a bit of workaround - we need to create another function which would behave like it iterates only through Value object, calling its unique variable (we would call it in special way), and to differentiate it from other objects, we will make it bound to try/except scheme. So, we will iterate over list of variables, but if except is risen, we skip it.
This will be put as next commit, with old function being @Deprecated, and nextly, removed. It is asked to put name of this issue for the commit, though, so it is easier to track the progress.
Eventually, there should be some sort of cleaning of the code - so, this issue will be closed when this parameter is set properly, not in such awful way.