Simplification of character creation code

Toma400 / The_Isle_of_Ansur

Python-based text RPG game, successor of Between Shadows and Light.

Other

9 stars 0 forks source link

Simplification of character creation code #16

Closed Toma400 closed 10 months ago

Toma400 commented 2 years ago

Additionally to #13, I'd request some simplification for character.py code, because it is just huge mess. And I'm pretty sure it can be made more readable, especially with further elements.

It is also inconsistent, since similar features were made differently, so some coherency should be also implemented.

Toma400 commented 2 years ago

Let's sum up and put it inside one issue, instead of several ones:

Let's clean the code (#16)
Let's improve creation of character step-wise:
- Better description of races/classes, I assume? (#13)
- Should be up-to-date with BRPGS 3.0 (#24)
- Should include avatars, name suggestions, story presets, game settings and possibly also religion
- Should go gender -> race -> name (suggestion by race/gender) -> class -> manual points -> religion -> story -> settings
- There should be a way to check all stats at the end and reenter the values if needed
  - This could require storing the info BEFORE the end, so the save would happen not during character creation, but once everything is selected (this way would automatically end #25, and it can use _temp folder)
Fix issues: #17, #18

Toma400 commented 2 years ago

Unlabeled all other issues from high priority, so this one's summary will serve as compilation tool. Quite a lot of work, all related to the same place, meh. Though preA2 will be about inventory managment, seems like no .-.

Toma400 commented 1 year ago

Additionally, there should be also:

[ ] A way to add character pictures - both provided by statpacks (should be race-exclusive sets), and by user himself. Any of those photos should save to profile, so if mod is removed, picture stays anyway.
[ ] All game-related settings should be chosen during game creations, not in settings. There's literally no point in that.

Toma400 commented 10 months ago

Everything here is done except for avatars, so I'm closing this issue and pushing the leftover to #88.

Character creation code is not simplified simply because we moved to rewritten one. So it's more like deprecated and soon to be removed.