Toma400 / The_Isle_of_Ansur

Python-based text RPG game, successor of Between Shadows and Light.
Other
9 stars 0 forks source link

Name refactoring in core/graphics #77

Closed Toma400 closed 7 months ago

Toma400 commented 1 year ago

As much as cool .py files in this directory sounds, I found myself struggling with navigating between them - their names are not clear enough for me to know which one holds what. This is why there's call to make it way smaller:

But most importantly, we should do something with names, as for hedgehog's sake, it's impossible to understand where are specific things in gh_manag.py, gh_objects.py, gh_system.py, gui_objects.py, gui_types.py. One file with more stuff may be tedious, but if you do it well and take out Deprecated functions, it should be okay. It has some benefits of clarity, and even benefits of categorisation (look at Forge API or some other "files big" libs)

Toma400 commented 9 months ago

Well, I could say that pre-alpha 3 will heavily improve what this issue is talking about, so this should be fully changed by either pre-alpha 3 or pre-alpha 4 (depending on how much will be needed for pre-alpha milestone)

Toma400 commented 8 months ago

This will be pushed into pre-alpha 4, because while we did some work on that, it isn't enough and will be continued along development.

Toma400 commented 7 months ago

a842459 has moved two elements into newly made deprecated folder, so it doesn't clutter as much space now

Toma400 commented 7 months ago

I think f715739 makes it mostly completed. Names are still not changed to anything blatantly obvious, but they are good enough (and most importantly, not crowded so heavily) to be recognised. Closing.