Transparent --button entries should be subject to window background color

[Botspot]

Setup:

xlunch with an opaque black background:

xlunch -bc 000000ff

I add a button to it:

xlunch -bc 000000ff \
--button "/path/to/proglogo.png;;0,0;"

Expected behavior:

proglogo.png is displayed "above" the black background, and any transparency in the image is now black.

Actual behavior:

proglogo.png punches a hole in the black background, and you can see right through the image to underlying elements.

Screenshot:

And here's proglogo.png, in case you wanted it for testing purposes:

Interestingly, when using a white background instead of a black one, this problem does not occur.

[PMunch]

Hmm, I think this might've been the thing that made icons translucent with a transparent background. What happens if you make the background ever so slightly translucent? We might need to add a logic switch in here somewhere.

[Botspot]

Hmm, I think this might've been the thing that made icons translucent with a transparent background. What happens if you make the background ever so slightly translucent?

The problem still occurs on a semi-transparent black background.

Interestingly, when using a white background, this problem does not occur and the image is as opaque as the rest of the window.

[Tomas-M]

Should by fixed by PMunch's latest changes, releasing as version 4.7.2 @Botspot please test too

[Botspot]

Should by fixed by PMunch's latest changes, releasing as version 4.7.2 @Botspot please test too

Looks great! I'll push necessary changes to Pi-Apps in a few minutes.