search

Tomas-M / xlunch

Graphical app launcher for X with minimal dependencies
http://xlunch.org
GNU General Public License v3.0
219 stars 37 forks source link

Error in help message #60

Closed PMunch closed 6 years ago

PMunch commented 6 years ago

The new -L, --highlightcolor is noted as the switch for the new highlight image option, where it should be -L, --highlight. This is true for both --help, the usage.txt, and the docs.

Tomas-M commented 6 years ago

I can see -L is in the help, but I didn't touch the code (-L was not used in the code before I took it). What to do now? Remove it from the help, or leave it there, implement -L for --highlightcolor, and use another letter for --highlight?

Tomas-M commented 6 years ago

We have currently 38 letters used, those are: abBcdefFgGhHiIlLmMnoOpPqrRsStTuvwWxXy That means we can still use ACDEjJkKNQUVYzZ

Tomas-M commented 6 years ago

So maybe use -C for highlightcolor?

Tomas-M commented 6 years ago

Ah, I misunderstood. I thought there is a --highlightcolor option ... Now I understand you. Sorry, going to fix. Still, we could use -C for --hc :-)

Tomas-M commented 6 years ago

Wait a moment, there is a 'highlightcolor' option. I should take a break, deep breath, .... :)

Tomas-M commented 6 years ago

Fixed by f60a4f7f7e9ff1f5cd319d23771579b33af38e67, thank you for notice

PMunch commented 6 years ago

Haha, glad you figured out what I meant in the end. But it's still wrong in the docs: https://github.com/Tomas-M/xlunch/blob/master/docs/index.html#L109

Tomas-M commented 6 years ago

Sorry I've missed that, fixed now f60a4f7f7e9ff1f5cd319d23771579b33af38e67