Tomas-M / xlunch

Graphical app launcher for X with minimal dependencies
http://xlunch.org
GNU General Public License v3.0
219 stars 37 forks source link

Feature request: comment support in the entries file #77

Closed neuromancer closed 6 years ago

neuromancer commented 6 years ago

It could be nice to have support to add comments in the entries files. Maybe we just ignore lines starting with # or //. For instance:

# emulators
ZSnes;extra/zsnes.png;/usr/bin/zsnes
Desmume;entra/desmume.png;/usr/bin/desmume
Tomas-M commented 6 years ago

I thought it is already implemented. Did you try that?

neuromancer commented 6 years ago

Yes. It fails. You can add comments in the config file but not in the entries file (using the --input parameter)

Tomas-M commented 6 years ago

@PMunch would you please look at it? Thank you

PMunch commented 6 years ago

Hmm, yeah I implemented it but only for configuration files. To be honest I just didn't think about adding it to the entries parsing. When I receive feedback on #78 I'll look into it as both require changes to the parser and it's easier to do them both at the same time :)

neuromancer commented 6 years ago

Thanks!

PMunch commented 6 years ago

Comments should be implemented in the latest version now (with # as the comment character). I also redid the parsing a bit so adding sections to the parser should be relatively easy. Still have to figure out how to do it as an implementation though..

neuromancer commented 6 years ago

Thanks!