TomasBeuzen / pybeach

A Python package for locating the dune toe on cross-shore beach profile transects.
MIT License
18 stars 12 forks source link

JOSS review by Sherwood issue 3 #3

Closed csherwood-usgs closed 4 years ago

csherwood-usgs commented 4 years ago

The example notebook https://github.com/TomasBeuzen/pybeach/blob/master/example/example.ipynb refers to pydune instead of pybeach. Unfortunately, there is also a package out there on GitLab called pydune. Installation of pybeach using pip install worked fine, and this example worked as indicated after I added the magic command %matplotlib inline. I notice scikit-learn is required...I already had that in my environment, but I don't think the documentation for pybeach indicates that it is required.

TomasBeuzen commented 4 years ago

I had originally called the package pydune until I found out that the name was already taken on PyPi (by a package that has not been updated since 2012!). I then changed the name to pybeach. Based on this comment:

kbarnhart commented 4 years ago

Just linking this with the JOSS Review