search

TomasTomecek / sen

Terminal User Interface for containers.
MIT License
990 stars 61 forks source link

Filters are lost when container list changes #85

Closed rocketraman closed 8 years ago

rocketraman commented 8 years ago

When I have a filter s=r set in sen, when the container list changes while on a different tab e.g. a container details tab, the filter is still set but the list is no longer filtered.

I am running the dev version, but this is an issue on the stable version as well.

TomasTomecek commented 8 years ago

I also experienced that filters are a bit clunky when mixed with other operations but didn't have a chance to open an issue, so thanks for doing so!

Right now I'm in process of significant rewrite of command system. Once that's done, I'll take a look in this.

TomasTomecek commented 8 years ago

this should be fixed in master now (had to rewrite it much); haven't tested extensively, will close this once 0.4 is out

rocketraman commented 8 years ago

this should be fixed in master now (had to rewrite it much); haven't tested extensively, will close this once 0.4 is out

It's definitely better. The filter now stays active. However, now I am seeing the filtered list does not update when the list of containers changes e.g. a container is stopped and a new one started with an updated image. The filtered list just keeps the old container listed. I do have the container open in a "detail" tab -- not sure if that makes a difference.

TomasTomecek commented 8 years ago

looks like that filtering needs even more care; before doing final release, I'll take care of this

TomasTomecek commented 8 years ago

Found it, finally! If an image had multiple names, only the first one was taken into account. So now, all names are being considered.

Could you please retest with master? If it doesn't work, I would appreciate detailed steps to reproduce since this is getting pretty complex.

I tested like this: I applied filter asdqwe. In other terminal I kept creating/removing containers with name asdqwe and I kept tagging and untagging an image with name asdqwe. The interface was being continuously updated and only correct objects were displayed.

TomasTomecek commented 8 years ago

This should be fixed in 0.4.0