TomasVotruba / bladestan

PHPStan analysis for Blade templates
https://tomasvotruba.com/blog/introducing-bladestan-phpstan-analysis-of-blade-templates/
MIT License
286 stars 13 forks source link

Remove fluent interface from FileNameAndLineNumberAddingPreCompiler::setFileName #14

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

From https://github.com/TomasVotruba/bladestan/pull/12#discussion_r1125698504

szepeviktor commented 1 year ago

make service method with fileName as argument to avoid miss-use

Sorry. I'm not able to understand what to put where. Could you help with a sentence? (the only two things I know: machine and human errors)

TomasVotruba commented 1 year ago

I'll try :)

Basically, these 2 methods should become one, with 2 arguments and 1 return value.

szepeviktor commented 1 year ago

@TomasVotruba Done: 1 DOS editor (mcedit) + 1 sub-junior person with policies!!

szepeviktor commented 1 year ago

@TomasVotruba Is it ready to launch?

TomasVotruba commented 1 year ago

Thank you :clap:

szepeviktor commented 1 year ago

You're welcome.

I want this tethered contribution again.