Closed szepeviktor closed 1 year ago
I have no idea how the package works now. I'll need a reproducer test case with failing CI.
May I contribute my default CI workflows? They are very long but 3 years of maintenance is included.
Give me a day or two to make CI pass first. I'm still rebooting package I've dperecated a year ago :)
https://packagist.org/packages/symplify/template-phpstan-compiler
If you come on Monday, that would be more useful for me :+1:
Got it! When used with nunomaduro/larastan
Blade files are ignored.
Larastan makes Bladestan ignore them.
That's not it.
The testing PR uses both larastan and bladestan: https://github.com/TomasVotruba/tomasvotruba.com/pull/1387
That PR does not set templatePaths
, so only blade files in view()
calls are checked.
...no, we have a default path.
I need to implement e2e testing. That will show this problem.
It might be good to look at how Larastan find view-strings
and use a similar way to determin if it's a template that should be analyzed. From what I can see it looks like email templates are also not analyzed since they do not use view()
, the same is true when a component uses $this->view()
instead of view()
.
Closing as this is now mixing many various issues and getting messy :)
To re-open, please provide reproducer first, even if Github repository :+1:
this is now mixing many various issues and getting messy :)
Yes!
From https://github.com/TomasVotruba/tomasvotruba.com/pull/1384#issuecomment-1454830723
I'm not sure.
with this configuration blade files are not checked.
this works.