search

TomasVotruba / bladestan

PHPStan analysis for Blade templates
https://tomasvotruba.com/blog/introducing-bladestan-phpstan-analysis-of-blade-templates/
MIT License
286 stars 13 forks source link

Test for including empty content #45

Closed AJenbo closed 1 year ago

AJenbo commented 1 year ago

Add test for https://github.com/TomasVotruba/bladestan/issues/42

szepeviktor commented 1 year ago

Please consider adding a test for totally empty files.

AJenbo commented 1 year ago

Oh, I actually did it that way initially but thought it would be more meaning full/realistic to have a file with some static content. Should add another file or just empty the file?

szepeviktor commented 1 year ago

Another one.

AJenbo commented 1 year ago

Done

AJenbo commented 1 year ago

Rebased and issue handled, ready for review/merge

TomasVotruba commented 1 year ago

Thanks :partying_face:

TomasVotruba commented 1 year ago

I'll fix the line conflict in test manually :+1:

AJenbo commented 1 year ago

Ok, hope you can also look at #52 as that is what's going to bring home the bagels for me :D

TomasVotruba commented 1 year ago

I'm on it :)