Make Code Analysis workflow uniform

TomasVotruba / bladestan

PHPStan analysis for Blade templates

https://tomasvotruba.com/blog/introducing-bladestan-phpstan-analysis-of-blade-templates/

MIT License

286 stars 13 forks source link

Make Code Analysis workflow uniform #8

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

upgrade actions/checkout
quote YAML string
composer exec is for running bins

TomasVotruba commented 1 year ago

Thanks for the PR!

I think changing these details is something not a priority at the moment. It adds maintenance and review cost for not much gain.

What would be really useful is to improve the real project testing and test fixture for your failures :+1: That's where the biggest value of this tool is. Could you check that?

szepeviktor commented 1 year ago

You know, Tomas. I understand this value thing but I think an iceberg is build from the bottom where no one sees any value. Nowadays IT (and other industries) are rapidly deteriorating.

szepeviktor commented 1 year ago

I'm thinking of adding one e2e test with an existing/popular Laravel app.

szepeviktor commented 1 year ago

Maybe https://github.com/monicahq/monica/tree/main/resources/views ...