search

TomasVotruba / bladestan

PHPStan analysis for Blade templates
https://tomasvotruba.com/blog/introducing-bladestan-phpstan-analysis-of-blade-templates/
MIT License
280 stars 13 forks source link

Fix $this type (#90) #99

Closed robchett closed 1 month ago

robchett commented 2 months ago

Phpstan has a special formatter for $this which it can't actually parse itself if used in an @var block. This replaces it with the underlying type of $this.

AJenbo commented 1 month ago

@TomasVotruba Could you take a look at this and see if it's ready for merge?

P.s. did I hear correctly in your recent talk that you have passed on maintenance of this project to someone else, and in that case who?

TomasVotruba commented 1 month ago

I've missed this, thanks for the ping :+1:

LGTM

TomasVotruba commented 1 month ago

P.s. did I hear correctly in your recent talk that you have passed on maintenance of this project to someone else, and in that case who?

Well, I'm only doing the merges lately. I think you're the one doing most of the work :)

If you're up to it, I can add you as a co-maintainer, so you can process this more independently

AJenbo commented 1 month ago

If you're up to it, I can add you as a co-maintainer, so you can process this more independently

Sure would be happy to.

This week I have been working on resolving the level 8 issues for the last of the 3 project I work on. So fare haven't found any further issues with Bladestan, so I have started thinking about how to resolve the performance issues and stale cache results.

TomasVotruba commented 1 month ago

@AJenbo Awesome, your plan good to me :+1: I've just sent the invitation.

It would be great to spread this to Laravel community, so people are aware of such cool package

AJenbo commented 1 month ago

I did a presentation on it for the Copenhagen Laravel community :)