search

TomasVotruba / class-leak

Find leaking classes that you never use... and get rid of them.
https://tomasvotruba.com/blog/how-to-avoid-maintaining-classes-you-dont-use
MIT License
88 stars 7 forks source link

Fix matching of `@api` class-comments #39

Closed staabm closed 6 months ago

staabm commented 6 months ago

before this PR, any class with just a comment - no matter what content this comment had - was handled like a @api commented class

TomasVotruba commented 6 months ago

Thank you :+1:

staabm commented 6 months ago

@TomasVotruba build should be fixed now :)

ruudk commented 6 months ago

Duplicate of https://github.com/TomasVotruba/class-leak/pull/36 ? 😄

TomasVotruba commented 6 months ago

Awesome :partying_face: thank you :+1:

staabm commented 6 months ago

thanks!

staabm commented 6 months ago

I have another edge case I want to fix - waiting for this one :)

ahh its already fixed in https://github.com/TomasVotruba/class-leak/commit/a69ea247434b50de3c685a61d3d797601eb35263

just waiting for a release then :-)

TomasVotruba commented 6 months ago

@staabm Better subscribe to releases here, already 2 versions are out :wink: