search

TomasVotruba / class-leak

Find leaking classes that you never use... and get rid of them.
https://tomasvotruba.com/blog/how-to-avoid-maintaining-classes-you-dont-use
MIT License
75 stars 6 forks source link

Add basic config file support #9

Closed NoiseByNorthwest closed 1 year ago

NoiseByNorthwest commented 1 year ago

The expected format is YAML and the only supported top level key is typesToSkip.

Resolves #8

TomasVotruba commented 1 year ago

I'm sorry, but this is taking way too much effort and I can't put more feedback in here.

Thank you for contributing, but I'm closing it to avoid bikesheeding.

NoiseByNorthwest commented 1 year ago

Next time I hope you will give a real specification to your contributors in order to avoid this kind of wast of time. And let me point out that "The same way other packages do " or "as convention for these tools." is not a specification.

Let me also add that neither phpunit nor phpstan have a default value of such flags.

The fallback logic is a bit more complex than you think and requires to process the user provided config and the default one separately if you want the default config to be optional (file allowed to be missing) which is not the case for the user provided one.