Tomash667 / carpg

Combination of action rpg with roguelike.
https://carpg.pl
MIT License
16 stars 15 forks source link

Perk/feat selection during character creation behaves incorrectly #421

Closed BottledByte closed 4 years ago

BottledByte commented 4 years ago

Custom build, latest commit: 86828c02b5a026df7430369558bfe5d5ffa63315

This bug makes selecting perks/feats a bit annoying due to frequent pop-up messages which say that perk was deselected because its requirements were not met and actually deselecting mentioned trait. It happens even when no requirements are really there (Or maybe they are not obvious, but I do not think so). This is recent build specific only, I was not able to reproduce on release 0.13. I estimate that recent perk de-hardcoding causes this and it seems that it is mainly associated with perks that have history flag, but other perks shows this behaviour sometimes when feat point gaining perks are selected and additional benefitial perks gets removed (so no feat point "lack" occurs). When two non-history traits are selected and one of them is then deselected, it works normally.

Steps to reproduce: 1) Start a new character, select a class 2) Assign perk Alchemist apprentice/Student of traveling merchant and some other perk (for example wealthy or sluggish), in any order 3) Change your mind and deselect the other perk 4) Observe a message saying "requirements not met, removing trait " 5) Both traits get deselected and there is no correlation between them apart from that pop-up message

scree

Tomash667 commented 4 years ago

Thanks, fixed.