numeric overflow when crafting in alchemy

Tomash667 / carpg

Combination of action rpg with roguelike.

https://carpg.pl

MIT License

16 stars 15 forks source link

numeric overflow when crafting in alchemy #435

Closed Lemiczek closed 4 years ago

Lemiczek commented 4 years ago

When a person has a singular magic stone or herb in inventory and tries to craft a small mana/health potion, the modal window to create multiple potions pops up. If a person then scrolls to create more potions the value -2147483648 (signed 2^31) pops up. the pop up then shows that -2147483648 potions were created but in reality, only 1 item was created.

Steps to reproduce:

Have alchemy skill
Get 1 mana crystal or 1 herb
Select a potion to create
scroll with the mouse wheel

Tomash667 commented 4 years ago

Fixed in 0.15.

Extra changes:

when player have ingredients for only 1 potion or when holding Control - create 1 potion without confirming
when holding Shift - create max potions