search

TomaszRewak / C-sharp-console-gui-framework

A GUI framework for C# console applications
MIT License
1.08k stars 45 forks source link

List view #24

Closed i-am-shodan closed 3 years ago

i-am-shodan commented 3 years ago

I needed a list view component that highlighted lines and allowed you to get the selected text on the screen.

i-am-shodan commented 3 years ago

I've completed the majority of the comments, few points of note remain but i'm not planning on making further changes

TomaszRewak commented 3 years ago

I've completed the majority of the comments, few points of note remain but i'm not planning on making further changes

Btw, if you are happy with the current state of the control (which I think is a valid view), it might be that it would be best to simply define it directly in your project. Classes like SimpleControl are exposed as public for this sole reason. Many of my PR comments relate to the fact that general purpose controls defined in this library have to account for multitude of edge cases and possible usage scenarios. In case of project-specific controls a lot of that can be assumed based on the actual requirements (like the coloring and resizing behaviors). And in case of those project-specific controls complexity associated with this abstraction level is even undesirable. It's just that when accepting contributions, I have to draw that line, striving only for more general-purpose controls.

i-am-shodan commented 3 years ago

As I said I’m not planning any further changes. Maybe you could consider a companion repo that contains user submitted controls without the associated rigor.

TomaszRewak commented 3 years ago

OK, closing the PR then. I don't think there is much upside in having a central repository for all custom controls, as with loosen rigor those controls would end up not being coherent (so probably should not be bundled together). I think I prefer how the community addresses it in WPF - where whoever feels like it releases his/her own package with controls of their liking. But even for those (or when just writing control implementations directly in your project), feel free to add me to PRs for a more loose review - always happy to help.