Tomato6966 / erela.js

An up to date Lavalink Wrapper, which makes it easy to use Lavalink within your Discord Bot!
Apache License 2.0
50 stars 25 forks source link

lavalink v4 supported 👍 #28

Open phamleduy04 opened 1 year ago

phamleduy04 commented 1 year ago

Lavalink just released v4 (still in beta) for lavalink. Do you plan to update erela.js to support to v4?

https://github.com/lavalink-devs/Lavalink/releases/tag/4.0.0-beta.1

Tomato6966 commented 1 year ago

It should already support v4, just add node#version = "v4" and node#useVersionPath = true

Tomato6966 commented 1 year ago

Nope it doesn'T support it, nvm it changed i will change it now

CustomTag commented 1 year ago

Looks like the new update wont work image

zoli456 commented 1 year ago

Did you fix when you mute/deafen the bot it switch back to websocket?

Tomato6966 commented 1 year ago

I just fixed it, the issue was related for link queries.

Now it all works for: Lavalink v2 Lavalink v3 rest/websocket Lavalink v4

If any more v4 issues (not lavalink related) are coming, please post it in here!

If you setup your nodes like that:

 nodes: [{
        // other information like, identifier, host, password, port, regions, retryDelay, retryAmount
        version: "v4",
        useVersionPath: true,
    }]

you can use the newest v4 lavalink version! Supporting the artwork urls ->> but also renaming it to thumbnail, so you don't have to do stuff!

Tomato6966 commented 1 year ago

Did you fix when you mute/deafen the bot it switch back to websocket?

This bug never occurred to me...

N1C0exe commented 1 year ago

Yea also mine reconnect to websocket when mute/deafen

CustomTag commented 1 year ago

Yea also mine reconnect to websocket when mute/deafen

Yeah this also happens to me image everytime I pause the music its using the websocket and not the rest one so idk if its a bug or something

Tomato6966 commented 1 year ago

Oh you mean in lavalink info logs, i thought you ment the erela.js error message(s)

Tomato6966 commented 1 year ago

https://github.com/Tomato6966/erela.js/commit/3784f91450a1637f5fbee40889ee84d4f2350d6c Theoredically fixed with that commit-push. However I'm unsure if it doesn't affect v2-v3

it was a method-call from the original erela.js which i was unsure why it was there, so i just let it be. i removed it now, and i think that was causing the warning methods...

Tomato6966 commented 1 year ago

If any other v4 issues are present, please hit me up!

CustomTag commented 1 year ago

I guess that the new Slim branches is broken as its giving me this error image

CustomTag commented 1 year ago

And this is also a issue I guess with the new Silm branches image

Tomato6966 commented 1 year ago

Slim branch isnt tested yet.. I will take a look soon tho (getting operated today)

CustomTag commented 1 year ago

Slim branch isnt tested yet.. I will take a look soon tho (getting operated today)

Okay thanks for letting me know