search

Tomato6966 / erela.js

An up to date Lavalink Wrapper, which makes it easy to use Lavalink within your Discord Bot!
Apache License 2.0
50 stars 25 forks source link

Change Requester type and add ManagerEvents Interface #32

Closed NedcloarBR closed 3 months ago

NedcloarBR commented 1 year ago

Hello Tomato6966 in this Pull Request I changed the typing of the Music Requester in the Search method of the Player with the purpose of being defined the id of the user instead of the object of the user as a whole so I see a performance gain in the sense of less memory being used and I added an interface to the manager events, so the user who has an EventHandler to start the Event in a separate file can get the name of the events more easily using the interface here's how I created my Bot's EventHandler that uses the BaseEvent to validate the Event which in turn uses the event interfaces to validate the names of the Events In the end this PR stuck in improving the quality of life of the developer who uses your fork of Erela.js

Some code changes was my IDE using ESLint to "fix" the code

Tomato6966 commented 12 months ago

Sorry but i wont support this, as this client is not maintained anymore by me, check out the readme