An autosplitting component's settings are serialized as XML elements inside of the active Splits file; the component's SetSettings is called by LiveSplit, and it should be responsible for reading and acting upon the serialized settings. Currently, all of our autosplitters' settings are booleans.
This PR fixes some recently-discovered issues:
Our SetSettings methods were reading false when the element was not yet serialized, thus effectively ignoring default values of true.
When applying the read values to the Settings menu for graphical display, the CheckBox.Checked values were not always updated to match the boolean setting; this was an oversight in copying the code from setting a RadioButton grouping.
Additionally, this PR fixes an issue where TR5's Option (Split Security Breach Cutscene) boolean and related CheckBox were not synchronized in a newly-created ComponentSettings.
All autosplitters received a rebuild and consequent version bump due to TRUtil changes.
An autosplitting component's settings are serialized as XML elements inside of the active Splits file; the component's
SetSettingsis called by LiveSplit, and it should be responsible for reading and acting upon the serialized settings. Currently, all of our autosplitters' settings are booleans.This PR fixes some recently-discovered issues:
SetSettingsmethods were readingfalsewhen the element was not yet serialized, thus effectively ignoring default values oftrue.CheckBox.Checkedvalues were not always updated to match the boolean setting; this was an oversight in copying the code from setting aRadioButtongrouping.Additionally, this PR fixes an issue where TR5's
Option(Split Security Breach Cutscene) boolean and related CheckBox were not synchronized in a newly-createdComponentSettings.All autosplitters received a rebuild and consequent version bump due to TRUtil changes.