Tombenpotter / Sanguimancy

Sanguimancy: A Blood Magic addon
http://minecraft.curseforge.com/mc-mods/223722-sanguimancy
10 stars 17 forks source link

Some Considerable work to update to 1.12.2 #134

Open AhiVT opened 5 years ago

AhiVT commented 5 years ago

I really wanted to use this mod in my 1.12 modpack and thought to give a shot at updating the project to 1.12.2. While I'm not in any way new to programming, I barely had any clue where to start with Forge modding. I put forth my best effort to update and fix as much as I could, but there is still much left to be done. It is my hope that pushing my changes to master will catch the eyes of other would-be modders looking to update the mod.

Tombenpotter commented 5 years ago

I’ve been very busy in the last few years, which is why Sanguimancy hasn’t been updated yet. I’ll take a look at this and see what I can do :) I’m almost completely done with school, so hopefully that’ll open up some more time I can use to get back into modding!

Le 30 juil. 2019 à 21:59, Joseph Zurowski notifications@github.com<mailto:notifications@github.com> a écrit :

@Kexerval commented on this pull request.


In src/main/java/tombenpotter/sanguimancy/api/tiles/IBoundTile.javahttps://github.com/Tombenpotter/Sanguimancy/pull/134#discussion_r308915465:

@@ -1,4 +1,4 @@ -package tombenpotter.sanguimancy.api.tile; +package tombenpotter.sanguimancy.api.tiles;

Refactor from 1.10.2 branch

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/Tombenpotter/Sanguimancy/pull/134?email_source=notifications&email_token=ABC6P45JFJHOX3ELJRXRYW3QCCMRZA5CNFSM4IH7XH3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCABQF5Y#pullrequestreview-268632823, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABC6P45DBV6DSZPRM77UMHDQCCMRZANCNFSM4IH7XH3A.