Tomekmularczyk / react-starter

Starter kit for react app
MIT License
8 stars 4 forks source link

Replace tslint with eslint #12

Open Tomekmularczyk opened 4 years ago

Tomekmularczyk commented 4 years ago

Replace current Tslint config with eslint: https://github.com/typescript-eslint/typescript-eslint

fandok commented 4 years ago

i would like to approach this issue if you may. but i want to know why do you want to change this into tslint?

Tomekmularczyk commented 4 years ago

@fandok the opposite - I want te to remove TSlint which is deprecated and use Eslint instead with TS config

fandok commented 4 years ago

and since u also use prettier, do you want to me to also config the prettier inside the eslint?

fandok commented 4 years ago

ahh, my bad :( okay i would love to if you may

Tomekmularczyk commented 4 years ago

@fandok take it :), also don't extend eslint config with a prettier config, I think it is not necessary

fandok commented 4 years ago

okaaaaay, i'll see what i can do

fandok commented 4 years ago

Hi @Tomekmularczyk i created PR for the issue, please look at it and review it. many thanks 💯