TomenetGame / tomenet

TomeNET is an online multiplayer roguelike role-playing game
https://www.tomenet.eu/
Other
69 stars 11 forks source link

Stable master #2

Closed jezek closed 4 years ago

jezek commented 4 years ago

Hello, this isn't much of an issue, it's more of an discussion about some enhancements/ideas.

It is a good practice, that the master branch is the latest stable release, possibly the same version that is running as server at europe.tomenet.eu and is advertised as latest client in download section of TomeNET page.

The idea is that the development is done in other branches (or in your fork) and is merged (pull request is filled) to master only when its is complete (possibly tested) and you are pretty confident that he code can be build and used as official server/client without troubles (this is meant only for code changes, documentation can be merged without issues).

Or tagging would be helpful, to mark the releases and latest stable.

This helps in community development in the future (less confusion) or if some build and deploy automation is needed.

I'm writing this on behalf of about 100 commits to master in past 5 days. I mean, it is very good, the development progresses with this pace (and kudos for the work), but a little bit organization will do only good.

Maybe some outline for guidelines for versioning & branching will be good. What are your thoughts about versioning, branching, release tagging and build automation?

mhirki commented 4 years ago

I don't currently see a need for a separate development branch. The master branch is relatively stable. People are supposed to test their changes locally before pushing or creating a pull request. The official server (europe.tomenet.eu) is updated quite frequently from the master branch.

I am going to tag at least the previous release so that people have some way of finding it through git.

jezek commented 4 years ago

Thanks for your prompt answer.

That's what I failed to communicate. I couldn't find out where one version stops and another begins. Tags did the work. Perfect. Issue solved.