search

TomerFi / aioswitcher

PyPi module integrating with various Switcher devices
https://aioswitcher.tomfi.info
Apache License 2.0
29 stars 18 forks source link

Stabilize flaky tests #713

Closed TomerFi closed 3 months ago

TomerFi commented 1 year ago

What did you have in mind?

The following test-cases are failing when the running machine's timezone differs from Asia/Jerusalem. Although the underlying devices are meant to work in Asia/Jerusalem, this situation prevents collaborators outside this timezone from passing tests locally. If I remember correctly, these test-cases also fail at a specific time, I think it was 00:00-00:01, but I'm not sure.

https://github.com/TomerFi/aioswitcher/blob/0544a5047ae1e9ae738f5b909b67c9af793e355e/tests/test_schedule_parser.py#L40

https://github.com/TomerFi/aioswitcher/blob/0544a5047ae1e9ae738f5b909b67c9af793e355e/tests/test_schedule_parser.py#L53

https://github.com/TomerFi/aioswitcher/blob/0544a5047ae1e9ae738f5b909b67c9af793e355e/tests/test_schedule_parser.py#L66

https://github.com/TomerFi/aioswitcher/blob/0544a5047ae1e9ae738f5b909b67c9af793e355e/tests/test_schedule_parser.py#L79

Are you trying to fix a problem?

No response

Any lead on how this feature can be implemented?

No response

YogevBokobza commented 1 year ago

Yes I saw this issue when developed the latest PRs.. Need to fix that..

YogevBokobza commented 9 months ago

@TomerFi Is that the fix done in https://github.com/TomerFi/aioswitcher/pull/752 ?

TomerFi commented 9 months ago

I don't think so...

TomerFi commented 8 months ago

@YogevBokobza #627 seems related to this.