chore: add s11 to discovery with it's added logic

TomerFi / aioswitcher

PyPi module integrating with various Switcher devices

https://aioswitcher.tomfi.info

Apache License 2.0

27 stars 19 forks source link

chore: add s11 to discovery with it's added logic #767

Closed YogevBokobza closed 3 months ago

YogevBokobza commented 4 months ago

Description

In this code we are adding s11 to the discovery part + it's added logic to support that + refactoring get function to support more than 1 runner

Related issue (if any): fixes #issue_number_goes_here

Checklist

[x] I have followed this repository's contributing guidelines.
[x] I will adhere to the project's code of conduct.

Additional information

Anything else?

TheSpringBoy commented 4 months ago

Hi, is it possible to add support to the light switches as well? Since you already dealt with the lights here..

YogevBokobza commented 4 months ago

Hi, is it possible to add support to the light switches as well? Since you already dealt with the lights here..

It is not related to this PR.. I rather not to add more parts and I am trying to have the minimum code every time so we can make a progress faster..

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 82.53968% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (runner-support-fixed@59b01ed). Learn more about missing BASE report.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## runner-support-fixed #767 +/- ## ======================================================= Coverage ? 97.33% ======================================================= Files ? 11 Lines ? 1200 Branches ? 0 ======================================================= Hits ? 1168 Misses ? 32 Partials ? 0 ```

TomerFi commented 3 months ago

@YogevBokobza @thecode - Thank you very much! I'm merging this.

Also, we need to rebase runner-support-fixed from the main.