TomerFi / aioswitcher

PyPi module integrating with various Switcher devices
https://aioswitcher.tomfi.info
Apache License 2.0
27 stars 19 forks source link

fix: incompatible toml-editor version in release workflow #769

Closed cdce8p closed 3 months ago

cdce8p commented 3 months ago

Description

The original https://github.com/ciiiii/toml-editor action seems to be unmaintained now. With the recent Github actions updates to node 20+, it has become incompatible.

Switch to a working fork: https://github.com/sandstromviktor/toml-editor https://github.com/ciiiii/toml-editor/compare/1.0.0...sandstromviktor:toml-editor:2.0.0

[!NOTE] It might be necessary to allow the action in the repo settings.

/CC @thecode

Checklist

TomerFi commented 3 months ago

@all-contributors add @cdce8p for code

allcontributors[bot] commented 3 months ago

@TomerFi

I've put up a pull request to add @cdce8p! :tada:

TomerFi commented 3 months ago

looks like this didn't fix the issue: https://github.com/TomerFi/aioswitcher/actions/runs/9235964986/job/25411319293

cdce8p commented 3 months ago

looks like this didn't fix the issue: https://github.com/TomerFi/aioswitcher/actions/runs/9235964986/job/25411319293

Actually it's working. See the previous step which builds successfully. https://github.com/TomerFi/aioswitcher/actions/runs/9235964986/job/25411319293#step:3:1 Unfortunately, I just missed one instance. Fixed in #771.