chore: add s11 control device

TomerFi / aioswitcher

PyPi module integrating with various Switcher devices

https://aioswitcher.tomfi.info

Apache License 2.0

27 stars 19 forks source link

chore: add s11 control device #777

Closed YogevBokobza closed 2 months ago

YogevBokobza commented 3 months ago

Description

Describe what you did and why.

Related issue (if any): fixes #issue_number_goes_here

Checklist

[x] I have followed this repository's contributing guidelines.
[x] I will adhere to the project's code of conduct.

Additional information

Anything else?

YogevBokobza commented 2 months ago

@TomerFi @thecode Please try to go over this PR when you can..

ido-re commented 2 months ago

@thecode @TomerFi -we'll be happy to get the Switcher light integrations to HASS :)

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 85.91549% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (runner-support-fixed@6bed050). Learn more about missing BASE report.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## runner-support-fixed #777 +/- ## ======================================================= Coverage ? 96.73% ======================================================= Files ? 11 Lines ? 1257 Branches ? 0 ======================================================= Hits ? 1216 Misses ? 41 Partials ? 0 ```

YogevBokobza commented 2 months ago

In future PR I will add more tests to fix the coverage percentage I also saw that currently, we are lacking "lights" parts in "message.py" which I will solve with tests next PR.

YogevBokobza commented 2 months ago

Please answer the unresolved comment

What unresolved comment? I answered everything..

YogevBokobza commented 2 months ago

Please answer the unresolved comment

You can see now.. Git decided to put my comments in pending..