feat: adding shutter state fetch

TomerFi / aioswitcher

PyPi module integrating with various Switcher devices

https://aioswitcher.tomfi.info

Apache License 2.0

27 stars 19 forks source link

feat: adding shutter state fetch #779

Closed YogevBokobza closed 2 months ago

YogevBokobza commented 2 months ago

Description

Describe what you did and why.

Related issue (if any): fixes #issue_number_goes_here

Checklist

[x] I have followed this repository's contributing guidelines.
[x] I will adhere to the project's code of conduct.

Additional information

Anything else?

TomerFi commented 2 months ago

@YogevBokobza Overall, it looks good; I have no comments - Great Job. Let's fix the failing tests. I'll take another look, and we'll wait for Shay also to give his blessings.

I would, however, change the title of the PR to something like "feat: adding shutter state fetch" or something like that.

YogevBokobza commented 2 months ago

@YogevBokobza Overall, it looks good; I have no comments - Great Job. Let's fix the failing tests. I'll take another look, and we'll wait for Shay also to give his blessings.

I would, however, change the title of the PR to something like "feat: adding shutter state fetch" or something like that.

Sure changed, Thanks.