search

TomerFi / aioswitcher

PyPi module integrating with various Switcher devices
https://aioswitcher.tomfi.info
Apache License 2.0
29 stars 18 forks source link

fix: add aiohttp to deps #801

Closed ayal closed 2 months ago

ayal commented 2 months ago

Description

add aiohttp to deps after this change: https://github.com/TomerFi/aioswitcher/commit/7c45f8bc3ed48e42df56f888a0ef09d4d6624a8a

Checklist

TomerFi commented 2 months ago

@ayal, Before merging, can you please document what's wrong with version 4.0.0 of aiohttp in the PR body?

thecode commented 2 months ago

@ayal, Before merging, can you please document what's wrong with version 4.0.0 of aiohttp in the PR body?

I just noticed this was added in a later commit after I approved the PR. The main idea was to make sure we don't need to create a new release when aiohttp will reach version 4.

As the one of the usages for aiohttp is going to be in Home Assistant and the most active developer in aiohttp is one of the Home Assistant core members I don't think there is a need to restrict anything. If there will be something breaking in aiohttp it will not be bumped in Home Assistant until all dependencies are compatible, if we restrict here we just force that we will not be compatible, but we don't know now anything that is not compatible.

ayal commented 2 months ago

@thecode @TomerFi Changed it now to allow any version. I'm used to a different version-pinning practice, i.e pin to a specific version and then use some bot (for example renovate) for upgrading versions (by a pr to test the upgrade, then auto-merge if successful). Major versions are specially indicative to breaking changes so should be even more careful.