TomerFi / switcher_webapi

Gain containerized access to your local Switcher smart devices
https://switcher-webapi.tomfi.info
Apache License 2.0
12 stars 10 forks source link

chore: support aioswitcher 3.4.1 #705

Closed YogevBokobza closed 10 months ago

YogevBokobza commented 10 months ago

Description

Describe what you did and why.

Related issue (if any): fixes #issue_number_goes_here

Checklist

Additional information

Anything else?

TomerFi commented 10 months ago

@YogevBokobza Thank you! Do you know if this will work for devices without a key? i.e., Cases where we have not request.query[KEY_LOGIN_KEY].

codecov[bot] commented 10 months ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (99f95c8) 97.66% compared to head (f24ff0d) 91.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #705 +/- ## ========================================== - Coverage 97.66% 91.94% -5.72% ========================================== Files 1 1 Lines 171 211 +40 ========================================== + Hits 167 194 +27 - Misses 4 17 +13 ```
YogevBokobza commented 10 months ago

@YogevBokobza Thank you! Do you know if this will work for devices without a key? i.e., Cases where we have not request.query[KEY_LOGIN_KEY].

login key must be set. even if it's just 00

TomerFi commented 10 months ago

login key must be set. even if it's just 00

This means this is a breaking change.

YogevBokobza commented 10 months ago

login key must be set. even if it's just 00

This means this is a breaking change.

Hmm.. Maybe I can question if request.query[KEY_LOGIN_KEY] is exists and if not then send "00" ?

YogevBokobza commented 10 months ago

login key must be set. even if it's just 00

This means this is a breaking change.

@TomerFi Can you check this commit? (https://github.com/TomerFi/switcher_webapi/pull/705/commits/2872c0f04decd564bfe3741abb150c20a8e0453c) Do you think it will work? I am not familiar with how to test this project.

TomerFi commented 10 months ago

login key must be set. even if it's just 00

This means this is a breaking change.

@TomerFi Can you check this commit? (2872c0f) Do you think it will work? I am not familiar with how to test this project.

LGTM

YogevBokobza commented 10 months ago

login key must be set. even if it's just 00

This means this is a breaking change.

@TomerFi Can you check this commit? (2872c0f) Do you think it will work? I am not familiar with how to test this project.

LGTM

So can we merge?

welcome[bot] commented 10 months ago

Congrats on merging your first pull request! Your contribution is highly appriciated!

TomerFi commented 10 months ago

@allcontributors add @YogevBokobza for code, doc, test

allcontributors[bot] commented 10 months ago

@TomerFi

I've put up a pull request to add @YogevBokobza! :tada:

TomerFi commented 10 months ago

Included in 1.2.5