Closed YogevBokobza closed 10 months ago
@YogevBokobza Thank you!
Do you know if this will work for devices without a key? i.e., Cases where we have not request.query[KEY_LOGIN_KEY]
.
Attention: 13 lines
in your changes are missing coverage. Please review.
Comparison is base (
99f95c8
) 97.66% compared to head (f24ff0d
) 91.94%.
@YogevBokobza Thank you! Do you know if this will work for devices without a key? i.e., Cases where we have not
request.query[KEY_LOGIN_KEY]
.
login key must be set. even if it's just 00
login key must be set. even if it's just 00
This means this is a breaking change.
login key must be set. even if it's just 00
This means this is a breaking change.
Hmm.. Maybe I can question if request.query[KEY_LOGIN_KEY] is exists and if not then send "00" ?
login key must be set. even if it's just 00
This means this is a breaking change.
@TomerFi Can you check this commit? (https://github.com/TomerFi/switcher_webapi/pull/705/commits/2872c0f04decd564bfe3741abb150c20a8e0453c) Do you think it will work? I am not familiar with how to test this project.
login key must be set. even if it's just 00
This means this is a breaking change.
@TomerFi Can you check this commit? (2872c0f) Do you think it will work? I am not familiar with how to test this project.
LGTM
login key must be set. even if it's just 00
This means this is a breaking change.
@TomerFi Can you check this commit? (2872c0f) Do you think it will work? I am not familiar with how to test this project.
LGTM
So can we merge?
Congrats on merging your first pull request! Your contribution is highly appriciated!
@allcontributors add @YogevBokobza for code, doc, test
@TomerFi
I've put up a pull request to add @YogevBokobza! :tada:
Description
Related issue (if any): fixes #issue_number_goes_here
Checklist
Additional information