TominoCZ / FancyBlockParticles

My MC mod that turns 2D digging particles 3D!
https://minecraft.curseforge.com/projects/fancy-block-particles
GNU General Public License v3.0
18 stars 8 forks source link

Particles appear transparent and flash between transparent/opaque when viewed from certain angles. #84

Closed KimJongUninstall closed 5 years ago

KimJongUninstall commented 6 years ago

Steps to reproduce issue:

Not entirely sure how to reproduce this. I originally assumed it was Optifine, given how infamous it is for changing rendering code, but removing it didn't resolve the issue. I don't have any shaders or other mods which change rendering code.

MC Version:

Minecraft 1.12.2

FBP Version:

FBP 2.4.0

Forge Version (e.g. 2604):

Forge 14.23.3.2681

TominoCZ commented 6 years ago

Post a screenshot if you can please. Does enabling/disabling VBOs fix it?

KimJongUninstall commented 6 years ago

2018-05-13_14 24 19 I tried disabling VBOs, didn't fix the issue. Here's what it looks like. Its only on the Block breaking particles, everything else works as intended. When viewing from certain angles it flashes between transparent and opaque, and rarely appears as intended.

I'm using the Mo'Bends mod, and a thought occurred that maybe its messing with the rendering of FBP, but removing the mod had no effect unfortunately.

ghost commented 6 years ago

Do the mods you have consist of only: "Mo' bends, Optifine, and FBP?"

If not, a full mod list or the game logs could be useful (as a gist or on a paste site)...

So that TominoCZ can look into it further.

This has personally never happened to me and I have over 60 mods while using FBP in 1.12.2...

KimJongUninstall commented 6 years ago

Here's a pastebin of my modlist. I've looked at every possible mod that could be causing this issue, and none seem to do the trick. https://pastebin.com/VW1dS4Km Its probably something blatantly obvious and i'm just wasting everyone's time here.

ghost commented 6 years ago

Well the game logs could also be useful to have along with the mod list.

KimJongUninstall commented 6 years ago

sorry, Here's the latest game log. https://pastebin.com/YmAXzUYK

Noxalas commented 6 years ago

I'm experiencing the same exact problem, tried to put this mod into my modpack and it happened to me too.

I also tried to put one mod at a time in, using KimJong's modlist as a reference for what mods may be causing it, but I didn't manage to find the specific mod causing it.

I have realized that it most probably has something to do with entities, though, because the bug is only in effect whenever I look in the direction of one.

Here's my list of mods at which point the bug starts to happen: https://pastebin.com/cvLnEyy8 (I normally have a lot more in this modpack.)

ghost commented 6 years ago

Could it be FoamFix?

Because that is something I noticed in both of your mods lists.

I have never experienced this, but I don't have foam fix installed.

Foam Fix description:

FoamFix is a mod designed to optimize post-1.7.10 modded Minecraft using simple, targeted optimizations. Observations show that Java heap usage (measured using VisualVM on the main menu) can drop by as much as 50%!

Normally it is optimization mods that mess with other things, especially graphically... So that is where my idea/assumption is coming from.

Can any of you can think of a mod that adds graphical additions/optimizations that could cause this bug... I am also a bit stumped on this...

TominoCZ commented 6 years ago

I am not entirely sure what could be causing this issue.. Did you guys try running FBP alone?

I am rewriting the mod in the rendering areas so it might get fixed in the next update.

Electrosynthesis commented 6 years ago

Hi. I had this problem intermittently and discovered it was being caused somehow by the "Pixie" mob from Glitchfiend's Familiar Fauna.

Relevant version information: Minecraft v1.12.2 Forge-14.23.4.2760 FancyBlockParticles-1.12.x-2.4.0.jar FamiliarFauna-1.12.2-1.0.10.jar

No other mods were installed in my test setup. Spawning in a Pixie causes block break particles to become semitransparent. Killing the Pixie causes them to revert back to opaque after a few seconds.

This doesn't fully explain Noxalas' case since Familiar Fauna is not in his modlist. Presumably it is another mod triggering the same bug.

TominoCZ commented 6 years ago

Yeah.. I think this will be fixed in the next version. Thanks for the info

TominoCZ commented 5 years ago

See if it works in 2.4.1 please.

Electrosynthesis commented 5 years ago

I did a quick test using a similar setup to before with the Familiar Fauna Pixie and there were no rendering problems with the fancy block particles. Thanks for the fix!

TominoCZ commented 5 years ago

Np ;)