TominoCZ / FancyBlockParticles

My MC mod that turns 2D digging particles 3D!
https://minecraft.curseforge.com/projects/fancy-block-particles
GNU General Public License v3.0
18 stars 8 forks source link

[Feature Request] Remove config restrictions & other things #97

Closed ViciousVinnyD closed 5 years ago

ViciousVinnyD commented 5 years ago

If you try increasing the particle limit past 5^3 the mod will automatically set it back to 5^3. I want more particles, so it would be nice if this was removed.

Also, I would like the option to disable random scaling. And the smooth transitions config option doesn't actually disable the smooth transitions.

TominoCZ commented 5 years ago

-Too many particles will kill your CPU and GPU, also if we keep going like 6^3, 7^3, the ammounts of particles would be 216 and 343 for one destroyed block... also it wouldn't look nice when they are frozen.. they would be overlapping

-You should be able to disable the random scaling. I'll look more into it.

-I'll be removing the smooth transition option as it doesn't help and is really just inconvenient.

ViciousVinnyD commented 5 years ago
TominoCZ commented 5 years ago

Yes, the smooth transitions will be enabled by default. I really don't want to remove the caps... how many particles do you need? Tell me the max value you'd like to be able to set with the slider.

You're right.. there is no option to disable the random scaling.. I just replaced the smooth transition option with an option to disable the random scale.

ViciousVinnyD commented 5 years ago

Perhaps double the default (8^3), that seems to be the safe upper limit for my GPU. The reason I wanted a high upper limit is because I wanted to simulate a block breaking into it's individual pixels by using a combination of cartoon mode, small particle size and a large particle number.

Also, as for your concerns about people crashing their computers with absurdly high particle counts; perhaps add a warning when setting the slider to a very high value. That way people who don't know how computers work are aware that this will cook their potato.

TominoCZ commented 5 years ago

Oh I see.. Well the thing is that the particles don't have the pixel color at that position of the texture... The particle texture is random, so it won't look anything like the original block. It would be really hard to implement so I don't think that's happening.

I'll raise the upper particle limit then :D

ViciousVinnyD commented 5 years ago

I know, that doesn't matter though. The block breaking into individual pixels is more than enough.

ghost commented 5 years ago

@TominoCZ @ViciousVinnyD

I just want to ask how the block turning into individual pixels concept would even work.

Would the mod rely on the resource pack, analyzing every single image file and relating it to a in game block to determine the pixel area of the image, and then cube that to get the pixel count of every single individual block, also extending further into analyzing the model files for blocks with geometry more complex then just being a 16 by 16 by 16 cube, (such as an anvil, or a crop that has textures converge at cross sections)?

If so, that process sounds resource intensive (I don't know if it actually is it just sounds like it).

And if what I described above is a completely fictional process, then please inform me on how it would work then, as I am very curious :)

(But the reason I mentioned resource pack is because if the individual particles thing is hard-coded to scale with Minecrafts default block pixel models, then resource packs may or may not break it? If the idea is supposed to to be the block breaking into "every single individual pixel")

Take above with a grain of salt.

Also just 16 by 16 by 16 cube alone produces 4,096 pixel particles per block...

An alternative would be to use the surface area of a block(s), but in a 16 by 16 by 16 cube that produces 1,536 pixels per block, which is still a tone of pixel particles.

TominoCZ commented 5 years ago

I 100% agree with @SextupleTap

ViciousVinnyD commented 5 years ago

@SextupleTap What you just described is indeed fictional. You simply use cartoon mode and small particle scale and each particle colors itself using a random pixel from the texture instead of using a random portion of the texure like it normally does. Yes, it creates 4096 particles, which is silly. A hollow square does indeed make this much more manageable, and would actually be quite nice to have.

Also this whole idea was just a concept I wanted to test but I was unable to because of the hardcoded restrictions, which I really don't like having. The in-game GUI limits the range anyway, so only advanced config users are actually able to set it to out of range values.

TominoCZ commented 5 years ago

The only way you could set it higher is by going into the memory of Minecraft using CheatEngine and changing the right variable xD

ghost commented 5 years ago

@ViciousVinnyD The reason I described that other process is because I do not like Cartoon Mode, and I like the pixels to look even more so like the block broken by retaining the texture pack texture. The main point was the volume and surface area particle voxel-pixel count anyways.

Also further more, proportionality of the particles position in relation to a blocks geometry is something that would make sense in my opinion if over 256 pixels are going to pop out per block at once.

Also who's to say if a process is fictional if they haven't tried coding it yet???

But at that scale and particle count it does make more sense for every pixel to take a random texture proportion or a single pixel color from the texture instead.

Besides, this suggestion thread is already done and completed anyways, being able to edit the config files to manually to bypass the in game restriction without having the config file reset will be nice to have.

TominoCZ commented 5 years ago

Yeah.. I think I can disable the config restrictions when you reload the config file ;)

ViciousVinnyD commented 5 years ago

@TominoCZ Yeah that would be great thanks. Limit the gui to prevent kids breaking their game, and remove it in configs so nerds can flex their graphics cards.

teak1 commented 5 years ago

was that limit ever removed? and if so from what versions?

TominoCZ commented 5 years ago

The restrictions will be removed in version 2.4.1. I've been busy and I began working on FBP again earlier today. The new version will be released soon.

TominoCZ commented 5 years ago

xD unlimited_scale