search

Tomm0017 / rsmod

New repository: https://github.com/rsmod/rsmod
https://github.com/rsmod/rsmod
Apache License 2.0
123 stars 100 forks source link

Pickpocketing #59

Closed ZenJakey closed 5 years ago

ZenJakey commented 5 years ago

What has been done?

Added the pickpocketing part of the Thieving skill. All normal pickpocket-able NPCs are included, but not quest NPCs.

Edit: Item tables are done to the best accuracy I could. All that may be wrong is the exact amounts that the weighting should be done by.

ZenJakey commented 5 years ago

Cheers! Glad it will be useful!

ZenJakey commented 5 years ago

Uh, that was a rebase.

ZenJakey commented 5 years ago

All fixed in 6b42613

ZenJakey commented 5 years ago

Fixed all of those, though, with NPC names, I added that in the kotlin script file, and just set a default for npcName in the enum to make sure I have support for Fremennik citizens and elves keeping the proper name for pickpocketing actions as on OSRS.

ZenJakey commented 5 years ago

Fixed an error in pickpocket.kts, corrected filename conventions, and changed the Rarity enums to constants. Should be complete.

ZenJakey commented 5 years ago

All done, thank you @notmeta