search

Tomm0017 / rsmod

New repository: https://github.com/rsmod/rsmod
https://github.com/rsmod/rsmod
Apache License 2.0
123 stars 100 forks source link

Player options #68

Closed tristonplummer closed 5 years ago

tristonplummer commented 5 years ago

What has been done?

Player option packets have been implemented into the packet pipeline, and plugin system. PawnPathAction has been mildly refactored to support both Players and Npcs. Interacting player attribute has been added, and default options (Follow, Trade) have been added into the osrs on_login plugin, though their functionality has not yet been implemented.

As requested in issue #67

Tomm0017 commented 5 years ago

The comment by @notmeta will be worked on after merging this PR. I had some feedback regarding the options methods inside the Player class. What we tried to do was to decouple revision-specific code from the core game module. In this case we can keep options set in the core Player class, since all revisions will have options for players, but we would want things like the PlayerOption enum and the methods that reference it, in the plugins module.

I will merge this PR since everything else seems good and I need to start on the documentation changes that were discussed.

Really good job on getting this PR out btw